[AIRFLOW-7029] Use separate docker image for running license check #7678
Conversation
|
Uses https://github.com/ashb/apache-rat-docker (which is set up to auto build). Happy to give other people maintainer rights on the repo. |
|
|
Glad we are slimming down the CI image :) |
Each stage of the CI tests needs to pull our `ci` image. By removing java from it we can save 1-2minutes from each test stage. This is part of that work.
ashb
force-pushed
the
separate-image-for-license-check
branch
from
7744258
to
c0d8969
Compare
| if ! docker run "${EXTRA_DOCKER_FLAGS[@]}" -t \ | ||
| --user "$(id -ur):$(id -gr)" \ | ||
| --rm \ | ||
| ashb/apache-rat:0.13-1 \ |
There was a problem hiding this comment.
Have you ever asked the application developers if they didn't want to start publishing an official image?
There was a problem hiding this comment.
I'm not really sure which project it's part of, it seems like a side project?
There was a problem hiding this comment.
This is the official Apache project. Here is the Github repository: https://github.com/apache/creadur-rat/
I've already added Docker to Travis CI, so the Docker image is an interesting next step forward.
https://github.com/apache/creadur-rat/blob/master/.travis.yml
…pache#7678) Each stage of the CI tests needs to pull our `ci` image. By removing java from it we can save 1-2minutes from each test stage. This is part of that work. (cherry picked from commit ef71ac6)
Each stage of the CI tests needs to pull our
ciimage. By removingjava from it we can save 1-2minutes from each test stage. This is part
of that work.
See AIRFLOW-7028 for reasoning.
Issue link: AIRFLOW-7029
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.