Standardize SecretBackend class names

[kaxil]

• AwsSsmSecretsBackend -> AwsSsmBackend
• CloudSecretsManagerSecretsBackend -> CloudSecretsManagerBackend
• VaultSecrets -> VaultBackend
• EnvironmentVariablesSecretsBackend -> EnvironmentVariablesBackend
• MetastoreSecretsBackend -> MetastoreBackend

---

Issue link: WILL BE INSERTED BY boring-cyborg

Make sure to mark the boxes below before creating PR: [x]

• Description above provides context of the change
• Unit tests coverage for changes (not needed for documentation changes)
• Commits follow "How to write a good git commit message"
• Relevant documentation is updated including usage instructions.
• I will engage committers as explained in Contribution Workflow Example.

---

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

cc @xinbinhuang

[xinbinhuang]

Nice! Like the name standardization. I am also thinking if we should standardize the connection_prefix (used in AWS SSM & GCP Secrets Manager) and connection_path ( in Hashicorp Vault)

[kaxil]

Nice! Like the name standardization. I am also thinking if we should standardize the connection_prefix (used in AWS SSM & GCP Secrets Manager) and connection_path ( in Hashicorp Vault)

What name would you suggest ?

[kaxil]

Options:

1. connections_path_prefix
2. connections_prefix
3. connections_path

What do others think @potiuk @ashb

[ashb]

Aws SSM is a suite of tools/products so calling it AwsSSMBackend is too generic. AwsSSMParameterStoreBackend (though it's too long a name)

[kaxil]

Aws SSM

How about AwsSecretsManager? (Based on https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)

[ashb]

In fact it seems that "SSM" is the "Systems Manager Agent" https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html.

The full product name of the feature we are using is the AWS Systems Manager Parameter Store.

[ashb]

I think SecretsManager may be something else. Go AWS!

[kaxil]

I think SecretsManager may be something else. Go AWS!

🤦‍♂ I am confused. WTH!

[kaxil]

AwsSystemsManagerParameterStoreBackend wow that name would be huge

SystemsManagerParameterStoreBackend ? We can remove aws as it is in module_path and providers path too.

[ashb]

https://docs.aws.amazon.com/systems-manager/latest/userguide/what-is-systems-manager.html

Systems Manager Service Name History

AWS Systems Manager (Systems Manager) was formerly known as " Amazon Simple Systems Manager (SSM) " and " Amazon EC2 Systems Manager (SSM) ". The original abbreviated name of the service, " SSM ", is still reflected in various AWS resources, including a few other service consoles. Some examples:

   Systems Manager Agent: SSM Agent

   Systems Manager parameters: SSM parameters

[ashb]

I think the "Store" part is not needed, so AwsSMParametersBackend, AwsSystemManagerParametersBackend or soemthing like that, or perhaps AwsSSMParametersBackend.

[kaxil]

SystemsManagerParametersBackend stripping AWS as we don't use GCP or Hashicorp in their respective backends too.

[xinbinhuang]

For some context, this is a snapshot of the parameter store service. So I feel like better to still have the ParameterStore part

[kaxil]

For some context, this is a snapshot of the parameter store service. So I feel like better to still have the ParameterStore part

Done

[xinbinhuang]

Options:

1. connections_path_prefix
2. connections_prefix
3. connections_path

What do others think @potiuk @ashb

Add a comment here to keep a record on what we discussed on Slack:

• @kaxil and I agree on using connections_prefix because it is more generic than path and may apply to different systems better (GCP Secrets Manager does not support /, so airflow/connections is invalid.)

[kaxil]

Options:

1. connections_path_prefix
2. connections_prefix
3. connections_path

What do others think @potiuk @ashb

Add a comment here to keep a record on what we discussed on Slack:

• @kaxil and I agree on using connections_prefix because it is more generic than path and may apply to different systems better (GCP Secrets Manager does not support /, so airflow/connections is invalid.)

Hey, Let's keep the args as it is. After reading some more docs on Hashicorp Vault and talking to Ash, I am going to not change the args for now.

[turbaszek]

LGTM