-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix #7861
[AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix #7861
Conversation
Need to rebase after #7861 is merged |
Should we add |
Codecov Report
@@ Coverage Diff @@
## master #7861 +/- ##
===========================================
+ Coverage 65.44% 86.60% +21.15%
===========================================
Files 927 927
Lines 44963 44972 +9
===========================================
+ Hits 29425 38946 +9521
+ Misses 15538 6026 -9512
Continue to review full report at Codecov.
|
Can you rebase your PR on master please |
a851519
to
d760723
Compare
@zhongjiajie @kaxil Just rebased. Going through Travis now. Should be good to go after that |
Travis green!. Let me know if you have any other comments. |
Thanks @xinbinhuang |
(cherry picked from commit f9c2263)
(cherry picked from commit f9c2263)
(cherry picked from commit f9c2263)
GCP Secrets Manager only accepts [a-zA-Z0-9-_]* as its valid secret id key. This PR fixes the implementation and adds checks in the constructor.
Screenshot at GCP Console
Issue link: AIRFLOW-7108
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.