Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Datetimepicker is visible on page load #8092

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Apr 3, 2020

Datetimepicker was visible on page load on Graph view, Log View, Tree
View, and Gantt chart, this was due to a fight between the old version
shipped with FAB and the version we now use.

Closes #8083 (as it does it in a different way).

Relates to #8046


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb ashb added the area:webserver Webserver related Issues label Apr 3, 2020
@ashb ashb added this to the Airflow 1.10.10 milestone Apr 3, 2020
@ashb ashb requested a review from kaxil April 3, 2020 10:11
Datetimepicker was visible on page load on Graph view, Log View, Tree
View, and Gantt chart, this was due to a fight between the old version
shipped with FAB and the version we now use.
@ashb ashb force-pushed the fix-datepicker-always-showing branch from 84e89b5 to 5307097 Compare April 3, 2020 10:51
@kaxil
Copy link
Member

kaxil commented Apr 3, 2020

Tests are passing.

@kaxil kaxil merged commit 10542e0 into apache:master Apr 3, 2020
kaxil added a commit that referenced this pull request Apr 3, 2020
Datetimepicker was visible on page load on Graph view, Log View, Tree
View, and Gantt chart, this was due to a fight between the old version
shipped with FAB and the version we now use.

(cherry-picked from 10542e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants