Use python client in BQ hook create_empty_table/dataset and table_exists #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:google
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
|
|
||
| table_resource = { | ||
| _table_resource: Dict[str, Any] = { |
There was a problem hiding this comment.
(With an eye to minimizing diff to make this easier to review), is there a reason to rename this variable?
There was a problem hiding this comment.
The reason is this line:
table_resource = table_resource or _table_resource
I wanted to avoid adding a big if clause and building this simple dictionray everytime is not a big performance issue I think.
mik-laj
reviewed
Apr 17, 2020
| table_id="test_view", | ||
| view={ | ||
| "query": "SELECT * FROM `{}.test_table`".format(DATASET_NAME), | ||
| "query": f"SELECT * FROM `{PROJECT_ID}.{DATASET_NAME}.test_table`", |
There was a problem hiding this comment.
Are we using legacy SQL or current SQL here?
There was a problem hiding this comment.
As you can see line below:
"useLegacySql": False
turbaszek
force-pushed
the
refactor-bg-create-empty-table
branch
from
5b03d3a
to
dedeef5
Compare
turbaszek
changed the title
|
@deJong would you like to take a look? |
|
I've run system test (without check operators that are broken on master) and it succeded. |
5 tasks
potiuk
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.