Fix performance degradation when updating dagrun state #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Apr 18, 2020
potiuk
approved these changes
Apr 18, 2020
|
@danfrankj out of interest: how big is your DAG? |
|
@BasPH we're at ~5000 tasks so when we upgraded recently, it ground to a halt. Also, pretty sure the CI failure here is unrelated? |
Catch credit goes to @cmlad :) |
kaxil
pushed a commit
that referenced
this pull request
Jun 18, 2020
Co-authored-by: Dan Frank <dan.frank@coinbase.com> (cherry picked from commit dd9f04e)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Dan Frank <dan.frank@coinbase.com> (cherry picked from commit dd9f04e)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Dan Frank <dan.frank@coinbase.com> (cherry picked from commit dd9f04e)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Co-authored-by: Dan Frank <dan.frank@coinbase.com> (cherry picked from commit dd9f04e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set comprehension
{t.task_id for t in dag.leaves}in the conditional is re-evaluated every for each loop in the outer list comprehension resulting in an O(n^2) computation and significant slowdowns on large dags.Introduced here: 8f6ca53#diff-32aa8dbb910719ef24a39cab5d0f2a97R302
Diagnosed and discovered by @cmlad
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.