Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task and dag stats on home page #8865

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

houqp
Copy link
Member

@houqp houqp commented May 14, 2020

In latest master, icon for all task and dag stats are broken on the home page.

root cause:

d.dag_id is not a valid attribute. in order to use dag_id variable
in a closure callback, it needs to be passed in as a fuction so the
right value can be captured for each for loop.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

d.dag_id is not a valid attribute. in order to use dag_id variable
in a closure callback, it needs to be passed in as a fuction so the
right value can be captured for each for loop.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label May 14, 2020
@kaxil kaxil merged commit dd57ec9 into apache:master May 19, 2020
@houqp houqp deleted the web_stats_fix branch May 19, 2020 16:17
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
d.dag_id is not a valid attribute. in order to use dag_id variable
in a closure callback, it needs to be passed in as a fuction so the
right value can be captured for each for loop.
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
d.dag_id is not a valid attribute. in order to use dag_id variable
in a closure callback, it needs to be passed in as a fuction so the
right value can be captured for each for loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants