Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better content of backport packages CHANGELOG and INSTALL files #9013

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 26, 2020

The content of Backport Packages CHANGELOG.txt and INSTALL files
has been updated to reflect that those are not full Airflow
releases.

  1. Source package:
  • INSTALL contains only references to preparing backport packages
  • CHANGELOG.txt contains combined change log of all the packages
  1. Binary packages:
  • No INSTALL
  • CHANGELOG.txt contains changelog for this package only
  1. Whl packages

No change


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested review from ashb, kaxil and mik-laj May 26, 2020 00:41
@potiuk potiuk force-pushed the better-content-of-changelog-install branch from 42d12b8 to 9b1be65 Compare May 26, 2020 01:18
The content of Backport Packages CHANGELOG.txt and INSTALL files
has been updated to reflect that those are not full Airflow
releases.

1) Source package:
- INSTALL contains only references to preparing backport packages
- CHANGELOG.txt contains combined change log of all the packages

2) Binary packages:
- No INSTALL
- CHANGELOG.txt contains changelog for this package only

3) Whl packages

No change
@potiuk potiuk force-pushed the better-content-of-changelog-install branch from 9b1be65 to ac51ecb Compare May 26, 2020 09:41
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment but LGTM

backport_packages/INSTALL Outdated Show resolved Hide resolved
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@potiuk potiuk merged commit 9764c90 into apache:master May 26, 2020
@potiuk potiuk deleted the better-content-of-changelog-install branch May 26, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants