-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADDITIONAL_PYTHON_DEPS #9031
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!. I will also add an option to extend Breeze with that option - but that can be done separately.
You can mark it as ready for review to merge it @wittfabian - or you might try to extend Breeze with an option to add --additional-python-deps flag if you are brave enough :) |
I have not yet worked with Breeze, but I would like to see the result ;) |
@potiuk Must the flag be added here? |
There are a few places - breeze-complete and breeze are the two scripts. You can just search for another flag and do it similarly, or I can add it later after your PRs are merged and cc: you in the PR. |
Awesome work, congrats on your first merged pull request! |
* add build-arg ADDITIONAL_PYTHON_DEPS * Add ADDITIONAL_PYTHON_DEPS example and description Co-authored-by: Fabian Witt <fabian.witt@redheads.de> (cherry picked from commit 6fc555d)
* add build-arg ADDITIONAL_PYTHON_DEPS * Add ADDITIONAL_PYTHON_DEPS example and description Co-authored-by: Fabian Witt <fabian.witt@redheads.de> (cherry picked from commit 6fc555d)
* add build-arg ADDITIONAL_PYTHON_DEPS * Add ADDITIONAL_PYTHON_DEPS example and description Co-authored-by: Fabian Witt <fabian.witt@redheads.de> (cherry picked from commit 6fc555d)
Description
Since we have separate "build" segment for the production image, We will need to add any extra dependencies there rather than on top of the base image if someone wants to add those dependencies.
Reference: #8604
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.