Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADDITIONAL_PYTHON_DEPS #9031

Merged
merged 3 commits into from
May 27, 2020
Merged

Add ADDITIONAL_PYTHON_DEPS #9031

merged 3 commits into from
May 27, 2020

Conversation

wittfabian
Copy link
Contributor

@wittfabian wittfabian commented May 27, 2020

Description

Since we have separate "build" segment for the production image, We will need to add any extra dependencies there rather than on top of the base image if someone wants to add those dependencies.

Reference: #8604


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented May 27, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!. I will also add an option to extend Breeze with that option - but that can be done separately.

@potiuk
Copy link
Member

potiuk commented May 27, 2020

You can mark it as ready for review to merge it @wittfabian - or you might try to extend Breeze with an option to add --additional-python-deps flag if you are brave enough :)

@wittfabian wittfabian marked this pull request as ready for review May 27, 2020 08:15
@wittfabian
Copy link
Contributor Author

I have not yet worked with Breeze, but I would like to see the result ;)
I am already working on #8866.

@wittfabian wittfabian mentioned this pull request May 27, 2020
6 tasks
@wittfabian
Copy link
Contributor Author

@potiuk Must the flag be added here?
https://github.com/apache/airflow/blob/master/breeze#L770

@potiuk
Copy link
Member

potiuk commented May 27, 2020

There are a few places - breeze-complete and breeze are the two scripts. You can just search for another flag and do it similarly, or I can add it later after your PRs are merged and cc: you in the PR.

@potiuk potiuk merged commit 6fc555d into apache:master May 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 27, 2020

Awesome work, congrats on your first merged pull request!

@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 5, 2020
potiuk pushed a commit that referenced this pull request Jun 9, 2020
* add build-arg ADDITIONAL_PYTHON_DEPS

* Add ADDITIONAL_PYTHON_DEPS example and description

Co-authored-by: Fabian Witt <fabian.witt@redheads.de>
(cherry picked from commit 6fc555d)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
* add build-arg ADDITIONAL_PYTHON_DEPS

* Add ADDITIONAL_PYTHON_DEPS example and description

Co-authored-by: Fabian Witt <fabian.witt@redheads.de>
(cherry picked from commit 6fc555d)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* add build-arg ADDITIONAL_PYTHON_DEPS

* Add ADDITIONAL_PYTHON_DEPS example and description

Co-authored-by: Fabian Witt <fabian.witt@redheads.de>
(cherry picked from commit 6fc555d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants