AMBARI-23932 - Ambari Metrics reports incorrect values in aggregated host metric data when requesting avg. #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host metric data when requesting avg.
swagle
reviewed
May 22, 2018
| } | ||
|
|
||
| private boolean isEventDownsampledMetric(String metricName) { | ||
| for (String pattern : eventMetricPatterns) { |
There was a problem hiding this comment.
Can this not be made a lookup instead of a match every time?
There was a problem hiding this comment.
It cannot be a simple metric name lookup since the number of metrics that could be 'event' type can be unbounded, and holding a Set of metric names may become costly.
|
Refer to this link for build results (access rights to CI server needed): |
swagle
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix regression introduced from AMBARI-23008.
How was this patch tested?
mvn clean install.
Manually verified known metric aggregate values on 2.6.2 and 2.7.0 clusters.