[AMBARI-22805] Improve Blueprints error handling in case of timeout #179

adoroszlai · 2018-01-24T07:30:17Z

What changes were proposed in this pull request?

This is a small addendum for #146 to improve behavior in case of timeout:

pass last seen error if present to callback, instead of TimeoutException
add message to the exception thrown when not all required hosts have joined the cluster
subtract retry delay from time left for subsequent attempt (since time left is calculated before scheduling with the delay)

Tested cluster provisioning failure with various timeouts. Added unit test.

…ve error message in case of timeout

…imeout edge case

asfgit · 2018-01-24T08:14:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/256/
Test PASSed.

adoroszlai added 2 commits January 24, 2018 00:48

AMBARI-22805. Blueprints do not handle some failures properly - impro…

666270c

…ve error message in case of timeout

AMBARI-22805. Blueprints do not handle some failures properly - fix t…

38af1bc

…imeout edge case

adoroszlai added the blueprint label Jan 24, 2018

adoroszlai self-assigned this Jan 24, 2018

adoroszlai requested review from rnettleton and benyoka January 24, 2018 07:30

adoroszlai requested a review from jonathan-hurley January 24, 2018 09:00

jonathan-hurley approved these changes Jan 24, 2018

View reviewed changes

benyoka approved these changes Jan 24, 2018

View reviewed changes

rnettleton approved these changes Jan 24, 2018

View reviewed changes

adoroszlai merged commit 51add12 into apache:branch-2.6 Jan 24, 2018

adoroszlai mentioned this pull request Jan 24, 2018

[AMBARI-22805] Improve Blueprints error handling in case of timeout #185

Merged