[AMBARI-22998] Wrong user used to execute the Spark/Livy Server service check

[rlevas]

What changes were proposed in this pull request?

common-services/SPARK/1.2.1/package/scripts/service_check.py:36

 livy_kinit_cmd = format("{kinit_path_local} -kt {smoke_user_keytab} {smokeuser_principal}; ")
 Execute(livy_kinit_cmd, user=params.livy_user)

Notice the Kerberos identity is for the smoke user, but the exec is for the livy user. This will replace the livy user's interactive Kerberos ticket cache.

This should be 

smoke_user_kinit_cmd = format("{kinit_path_local} -kt {smoke_user_keytab} {smokeuser_principal}; ")
Execute(smoke_user_kinit_cmd, user=params.smoke_user)

Where smoke_user is

smoke_user =  config['configurations']['cluster-env']['smokeuser']

This is similar for SPARK2 as well.

How was this patch tested?

Tested manually with original code to see the issue and then fix the fixed code to see it working properly:

2018-02-15 03:15:04,058 - Using hadoop conf dir: /usr/hdp/2.6.5.0-96/hadoop/conf
2018-02-15 03:15:04,061 - Execute['/usr/bin/kinit -kt /etc/security/keytabs/spark.headless.keytab spark-c1@EXAMPLE.COM; '] {'user': 'spark'}
2018-02-15 03:15:04,085 - Execute['/usr/bin/kinit -kt /etc/security/keytabs/smokeuser.headless.keytab ambari-qa-c1@EXAMPLE.COM; '] {'user': 'ambari-qa'}
2018-02-15 03:15:04,109 - Execute['curl -s -o /dev/null -w'%{http_code}' --negotiate -u: -k http://c6403.ambari.apache.org:18081 | grep 200'] {'logoutput': True, 'tries': 5, 'user': 'spark', 'try_sleep': 3}
200
2018-02-15 03:15:04,356 - Execute['curl -s -o /dev/null -w'%{http_code}' --negotiate -u: -k http://c6402.ambari.apache.org:8999/sessions | grep 200'] {'logoutput': True, 'tries': 3, 'user': 'livy', 'try_sleep': 1}
200

Command completed successfully!

Please review Ambari Contributing Guide before opening a pull request.

[swagle]

No unit test changes needed?

[rlevas]

@swagle , @zeroflag .. please recheck. I needed to make a small change to make the original change make sense.

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/616/
Test FAILed.
Test FAILured.

[rlevas]

@swagle There appears to be no unit tests for this and since we are trying to get this in quickly, I didn't want to spend the time trying to figure out how to build a Python unit test from scratch.

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/620/
Test FAILed.
Test FAILured.

[rlevas]

retest this please

[asfgit]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/635/
Test PASSed.