Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambari 22897 Tez view button doesnt works in ambari hiveviews 1.5 #408

Merged
merged 5 commits into from
Mar 8, 2018

Conversation

Akhilsnaik
Copy link

@Akhilsnaik Akhilsnaik commented Feb 20, 2018

What changes were proposed in this pull request?

Ambari 22897 - Tez view button doesnt works in ambari hive views 1.5

Visual-explain, visualization , tez , and settings was 'views' is not made route due to those buttons where not working as it was hitting : emberjs/ember.js#10780

How was this patch tested?

Tested the UI changes
All works fine

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57.113 s
[INFO] Finished at: 2018-02-20T16:31:12+05:30
[INFO] Final Memory: 62M/521M

UT cases corrected and folder made correct
[INFO]
[INFO] Tests run: 94, Failures: 0, Errors: 0, Skipped: 0

No change to Apperance even though there are changes in the implementation logic.

@asfgit
Copy link

asfgit commented Feb 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/699/
Test FAILed.
Test FAILured.

Copy link
Contributor

@venkatasairamlanka venkatasairamlanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add licence to "contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/query-settings.js" and do not use -Drat.skip when using mvn clean install

@asfgit
Copy link

asfgit commented Mar 8, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1037/
Test FAILed.
Test FAILured.

…he Unused code, layout settings tab correctly(asnaik)
Copy link
Contributor

@venkatasairamlanka venkatasairamlanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pallavkul-zz
Copy link

LGTM.

@venkatasairamlanka venkatasairamlanka merged commit 973d875 into apache:trunk Mar 8, 2018
@asfgit
Copy link

asfgit commented Mar 8, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1039/
Test FAILed.
Test FAILured.

@Akhilsnaik Akhilsnaik deleted the AMBARI-22897 branch March 13, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants