Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enable flag to oidc function #2672

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Nov 28, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add a switch to OIDC authentication to allow users to turn that feature off and turn it off by default.

Related issues

next #2608

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 self-assigned this Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #2672 (bcd1248) into master (8dcadce) will decrease coverage by 9.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
- Coverage   63.84%   54.26%   -9.59%     
==========================================
  Files         186       86     -100     
  Lines        7166     4458    -2708     
  Branches      873      268     -605     
==========================================
- Hits         4575     2419    -2156     
+ Misses       2388     1836     -552     
  Partials      203      203              
Flag Coverage Δ
backend-unit-test 50.08% <100.00%> (+0.01%) ⬆️
frontend-e2e-test 67.98% <ø> (-8.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/conf/conf.go 66.22% <100.00%> (+0.22%) ⬆️
web/src/helpers.tsx 19.67% <0.00%> (-57.38%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/pages/Consumer/List.tsx 73.17% <0.00%> (-19.52%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <0.00%> (-17.00%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
web/src/components/Plugin/UI/cors.tsx 71.11% <0.00%> (-11.12%) ⬇️
... and 106 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bzp2010 bzp2010 merged commit 1a107ec into apache:master Nov 28, 2022
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants