Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin configuration lost in editor #2718

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2696

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #2718 (4e6c304) into master (7b8d9c5) will increase coverage by 21.33%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2718       +/-   ##
===========================================
+ Coverage   55.01%   76.34%   +21.33%     
===========================================
  Files         104      139       +35     
  Lines        2983     3754      +771     
  Branches      743      874      +131     
===========================================
+ Hits         1641     2866     +1225     
+ Misses       1342      888      -454     
Flag Coverage Δ
frontend-e2e-test 76.34% <100.00%> (+21.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 75.40% <100.00%> (ø)
web/src/components/Plugin/UI/api-breaker.tsx 69.23% <0.00%> (ø)
web/src/pages/SSL/List.tsx 88.46% <0.00%> (ø)
web/src/pages/Consumer/List.tsx 92.68% <0.00%> (ø)
...eb/src/pages/PluginTemplate/components/Preview.tsx 100.00% <0.00%> (ø)
web/src/pages/Consumer/service.ts 90.00% <0.00%> (ø)
web/src/pages/SSL/components/Step2/index.tsx 100.00% <0.00%> (ø)
web/src/pages/Proto/List.tsx 100.00% <0.00%> (ø)
web/src/pages/Service/transform.ts 100.00% <0.00%> (ø)
web/src/pages/Service/components/Preview.tsx 100.00% <0.00%> (ø)
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Baoyuantop Baoyuantop merged commit 688afa2 into apache:master Jan 20, 2023
@Baoyuantop Baoyuantop deleted the fix-plugin-config branch January 20, 2023 08:16
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
juzhiyuan added a commit that referenced this pull request Feb 22, 2023
Co-authored-by: Baoyuan <baoyuan.top@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.15.0版本client-control配置后显示问题
5 participants