feat: change etcd prefix for ssl and proto #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
===========================================
- Coverage 66.96% 55.87% -11.10%
===========================================
Files 198 183 -15
Lines 7750 7089 -661
Branches 870 870
===========================================
- Hits 5190 3961 -1229
- Misses 2258 2925 +667
+ Partials 302 203 -99
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bzp2010
requested review from
LiteSun,
nic-chen,
starsz,
Baoyuantop and
juzhiyuan
juzhiyuan
approved these changes
Dec 22, 2022
soulbird
approved these changes
Dec 22, 2022
spacewander
approved these changes
Dec 22, 2022
tzssangglass
approved these changes
Dec 22, 2022
starsz
approved these changes
Dec 22, 2022
|
Thanks to all reviewers! 🙏 |
hongbinhsu
added a commit
to fitphp/apix-dashboard
that referenced
this pull request
Jan 30, 2023
* upstream/master: feat: release 3.0.0 (apache#2722) Revert "feat: release 2.16.0 (apache#2719)" (apache#2721) feat: release 2.16.0 (apache#2719) fix: plugin configuration lost in editor (apache#2718) fix: adapt APISIX plugin disabled (apache#2717) feat: basic support Apache APISIX 3.0.0 (apache#2701) feat: change etcd prefix for ssl and proto (apache#2693) fix: remove cases external service dependency (apache#2697) chore: simplify e2e environment (apache#2694) chore: optimize "allow_origins_by_regex tooltip" description (apache#2690) feat: release 2.15.0 (apache#2685) feat: basic support Apache APISIX 2.15.0 (apache#2680) feat: release 2.14.0 (apache#2677) fix: bump go version to 1.16 (apache#2678) feat: release 2.13.1 (apache#2658) feat: support more upstream scheme (apache#2675) feat: support purge method (apache#2674) feat: add enable flag to oidc function (apache#2672) # Conflicts: # web/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
APISIX 3.0 changed its TLS certificate (SSL), Protocol Buffer (proto) to use the etcd prefix, adding a plural suffix to it. We need to modify it for adaptation.
This is essential as an interim measure for our APISIX 3.0 compatibility on the APISIX Dashboard 2.x branch.
ssltosslsprototoprotosChecklist: