Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize "allow_origins_by_regex tooltip" description #2690

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

mscb402
Copy link
Contributor

@mscb402 mscb402 commented Dec 12, 2022

On the Cors plugin config page, the allow_origins_by_regex help message is misleading the user.

This PR optimize "allow_origins_by_regex tooltip" description。

Related issues

fix/resolve #2669

@mscb402
Copy link
Contributor Author

mscb402 commented Dec 13, 2022

@tokers @bzp2010 please help to review

@SkyeYoung SkyeYoung changed the title chroe: optimize "allow_origins_by_regex tooltip" description chore: optimize "allow_origins_by_regex tooltip" description Dec 13, 2022
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web/src/components/Plugin/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/components/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved
@@ -49,7 +49,7 @@ export default {
'component.pluginForm.cors.allow_origins_by_metadata.tooltip':
'Eklenti meta verilerindeki allow_origins kümesine başvurarak CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirin.',
'component.pluginForm.cors.allow_origins_by_regex.tooltip':
'CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirmek için normal ifade ifadeleri kullanın, örneğin, [".*.test.com"], test.comun tüm alt alan adlarını eşleştirmek için kullanabilir.',
'CORSu etkinleştirmek için izin verilen kaynakları eşleştirmek için regex ifadelerini kullanın. Her form sadece tek bir, bağımsız düzenli ifadeyle yapılandırılabilir, örneğin ".*.test.com" gibi, test.com\'un her alt etki alanını eşleştirebilir.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mscb402 and others added 3 commits December 14, 2022 14:50
Co-authored-by: Zeping Bai <bzp20000818@gmail.com>
Co-authored-by: Zeping Bai <bzp20000818@gmail.com>
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2690 (83f1033) into master (a1ffd33) will increase coverage by 4.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2690      +/-   ##
==========================================
+ Coverage   63.85%   67.98%   +4.12%     
==========================================
  Files         186       39     -147     
  Lines        7172     1040    -6132     
  Branches      874      268     -606     
==========================================
- Hits         4580      707    -3873     
+ Misses       2389      333    -2056     
+ Partials      203        0     -203     
Flag Coverage Δ
backend-unit-test ?
frontend-e2e-test 67.98% <ø> (-8.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 19.67% <0.00%> (-57.38%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/pages/Consumer/List.tsx 73.17% <0.00%> (-19.52%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <0.00%> (-17.00%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
web/src/components/Plugin/UI/cors.tsx 71.11% <0.00%> (-11.12%) ⬇️
web/src/components/Plugin/PluginDetail.tsx 64.48% <0.00%> (-10.93%) ⬇️
... and 153 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bzp2010 bzp2010 merged commit c1cf4d4 into apache:master Dec 14, 2022
@mscb402 mscb402 deleted the fix_issues_2669 branch December 14, 2022 07:43
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: cors plugin config 'allow_origins_by_regex' help message is mislead for user
5 participants