Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump go version to 1.16 #2678

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

ronething
Copy link
Contributor

@ronething ronething commented Dec 1, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

User who install apisix-dashboard from source will know go version need 1.16+

Related issues

#2673 (comment)

because of etcd client v3.5.5 require io/fs, then we need upgrade go version to 1.16+

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@ronething ronething changed the title fix: dump go version to 1.16 fix: bump go version to 1.16 Dec 2, 2022
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #2678 (1f1c3a8) into master (a5d96f8) will increase coverage by 5.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
+ Coverage   68.59%   74.08%   +5.49%     
==========================================
  Files         139      201      +62     
  Lines        3754     7833    +4079     
  Branches      874      874              
==========================================
+ Hits         2575     5803    +3228     
- Misses       1179     1728     +549     
- Partials        0      302     +302     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.04% <ø> (?)
backend-unit-test 50.08% <ø> (?)
frontend-e2e-test 76.34% <ø> (+7.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/api-breaker.tsx 69.23% <0.00%> (-5.13%) ⬇️
api/internal/core/store/store.go 87.55% <0.00%> (ø)
api/internal/log/zap.go 65.51% <0.00%> (ø)
api/cmd/version.go 57.14% <0.00%> (ø)
...rnal/handler/data_loader/loader/openapi3/export.go 0.00% <0.00%> (ø)
api/internal/log/log.go 60.00% <0.00%> (ø)
api/internal/filter/recover.go 7.69% <0.00%> (ø)
api/internal/core/storage/etcd.go 53.50% <0.00%> (ø)
api/internal/handler/healthz/healthz.go 100.00% <0.00%> (ø)
api/internal/core/server/server.go 62.50% <0.00%> (ø)
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juzhiyuan juzhiyuan merged commit 731dd6f into apache:master Dec 2, 2022
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants