Skip to content

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 28, 2025

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

The ApisixUpstream.portLevelSettings is already supported in version 1.x, but has not been implemented in version 2.x.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan requested a review from Copilot September 28, 2025 01:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for portLevelSettings to the ApisixUpstream CRD, allowing different upstream configurations to be applied based on the service port being accessed. This enables more granular control over upstream behavior such as different schemes (HTTP/HTTPS) or host headers per port.

  • Refactored upstream translation to accept port parameter and apply port-specific configurations
  • Added comprehensive test coverage for port-level settings functionality
  • Updated test infrastructure to support SSL/TLS testing

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/adc/translator/apisixupstream.go Refactored upstream translation logic to support port-level configurations
internal/adc/translator/apisixroute.go Updated route translation to pass port information to upstream translator
test/e2e/crds/v2/upstream.go Added comprehensive test cases for port-level settings feature
test/e2e/framework/nginx.go Added SSL secret deployment for testing HTTPS functionality
test/e2e/framework/manifests/nginx.yaml Enhanced nginx test configuration with SSL support and dual services
test/e2e/framework/apisix_consts.go Added SSL certificates and keys for testing
config/rbac/role.yaml Minor formatting change to resource ordering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlinsRan AlinsRan requested a review from Copilot September 28, 2025 01:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlinsRan AlinsRan marked this pull request as ready for review September 28, 2025 01:27
Copy link

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the test cases

@AlinsRan AlinsRan requested a review from ronething September 29, 2025 00:55
@AlinsRan AlinsRan merged commit fe5c135 into apache:master Sep 29, 2025
28 of 29 checks passed
@AlinsRan AlinsRan deleted the feat-au-port-level-seting branch September 29, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants