-
Notifications
You must be signed in to change notification settings - Fork 356
feat(apisixupstream): support portLevelSettings #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for portLevelSettings
to the ApisixUpstream CRD, allowing different upstream configurations to be applied based on the service port being accessed. This enables more granular control over upstream behavior such as different schemes (HTTP/HTTPS) or host headers per port.
- Refactored upstream translation to accept port parameter and apply port-specific configurations
- Added comprehensive test coverage for port-level settings functionality
- Updated test infrastructure to support SSL/TLS testing
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
internal/adc/translator/apisixupstream.go | Refactored upstream translation logic to support port-level configurations |
internal/adc/translator/apisixroute.go | Updated route translation to pass port information to upstream translator |
test/e2e/crds/v2/upstream.go | Added comprehensive test cases for port-level settings feature |
test/e2e/framework/nginx.go | Added SSL secret deployment for testing HTTPS functionality |
test/e2e/framework/manifests/nginx.yaml | Enhanced nginx test configuration with SSL support and dual services |
test/e2e/framework/apisix_consts.go | Added SSL certificates and keys for testing |
config/rbac/role.yaml | Minor formatting change to resource ordering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the test cases
Type of change:
What this PR does / why we need it:
The
ApisixUpstream.portLevelSettings
is already supported in version 1.x, but has not been implemented in version 2.x.Pre-submission checklist: