Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Search Icon overlays Dark Mode toggle in mobile view #1719

Closed
Keshav-0907 opened this issue Oct 31, 2023 · 11 comments · Fixed by #1752
Closed

[Site] Search Icon overlays Dark Mode toggle in mobile view #1719

Keshav-0907 opened this issue Oct 31, 2023 · 11 comments · Fixed by #1752
Assignees
Labels

Comments

@Keshav-0907
Copy link

Current State

Description of the current state/issue:

The Search icon overlays, the Dark Mode toggle button in Mobile View in the navbar.

Link to the page: https://apisix.apache.org/docs/apisix/getting-started/README/

Screenshots (if relevant):
Screenshot 2023-10-31 at 4 29 59 PM

Desired State

Description of the change you are proposing:

Adjusting both the objects, so that they don't overlay each other

Would you like to fix this issue?

Yes! Count me in

@SylviaBABY
Copy link
Member

@Keshav-0907 thanks for your contribution!

@yzeng25 yzeng25 changed the title Search Icon overlays Dark Mode toggle in mobile view [Site] Search Icon overlays Dark Mode toggle in mobile view Oct 31, 2023
@yzeng25 yzeng25 added Bug Something isn't working UI and removed Bug Something isn't working labels Oct 31, 2023
@Keshav-0907
Copy link
Author

@SylviaBABY @yzeng25

While setting up the project locally got this error repeatedly. Can you please help me find a solution for this ??

image

@yzeng25
Copy link
Contributor

yzeng25 commented Nov 3, 2023

@SylviaBABY @yzeng25

While setting up the project locally got this error repeatedly. Can you please help me find a solution for this ??

image

cc @SkyeYoung

@SkyeYoung
Copy link
Member

@Keshav-0907 Hi, Sorry to reply to you so late (I've been getting a lot of emails lately, so I'm missing some).

What system are you using? Since I only develop on Linux, there may be some compatibility issues.

@Keshav-0907
Copy link
Author

No worries @SkyeYoung

I am using a M1 Chip - Macbook

@SkyeYoung
Copy link
Member

Okay, I'll go find a Macbook and try it out a little later after I post this comment

@Keshav-0907
Copy link
Author

Okay, Thank you :)

@SkyeYoung
Copy link
Member

Sorry, last weekend I had some other things to do at the last minute. I will try today.

@SkyeYoung
Copy link
Member

SkyeYoung commented Nov 14, 2023

@Keshav-0907 Hi, it looks very strange. I didn't find the issue described in your image, but instead encountered some other problems (which I have addressed in this PR).

Could you please try manually accessing the path as described in the command?

e.g.:

# replace the apisix-website/scripts/generate-event-poster-card.sh
SCRIPT=$(readlink -f "$0")
SCRIPTPATH=$(dirname "$SCRIPT")/..

test -e ${SCRIPTPATH}/config/event-poster-card.json 
test -e ${SCRIPTPATH}/website/src/theme/Footer/

@siyaramaa
Copy link
Contributor

@SkyeYoung Hi, it looks like the issue with the search icon overlapping the theme toggle button is only happening when initially opening the page on desktop and switching to mobile view. However, the problem is resolved when you refresh the page after the switch or when initially opening it on mobile devices. When switching to the mobile view, the toggle button is moving to the collapsed side menu, but it's not removed or hidden from the right-side nav, as shown in the gif below.
i-1719

@siyaramaa
Copy link
Contributor

Hi, It was only a problem in the docs route and I've fixed the issue locally and would love to contribute. Could you please assign this task to me for confirmation? Thank you! 😊

@SkyeYoung SkyeYoung assigned siyaramaa and unassigned Keshav-0907 Jan 3, 2024
siyaramaa added a commit to siyaramaa/apisix-website that referenced this issue Jan 3, 2024
siyaramaa added a commit to siyaramaa/apisix-website that referenced this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants