bug: /apisix/admin 不能被正确的转发

[frf12]

Issue description

/apisix/admin的路径会因为匹配/apisix/admin而被转发给apisix admin模块

Environment

• apisix version (cmd: apisix version): 2.3
• OS (cmd: uname -a): centos7
• OpenResty / Nginx version (cmd: nginx -V or openresty -V):1.19.3.1
• etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API):3.4.0
• apisix-dashboard version, if have:2.3

Minimal test code / Steps to reproduce the issue

1.创建一个路由，将foo.com域名的请求都转发到127.0.0.1:8888

curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
    "name": "test",
    "uri": "/*",
    "hosts": ["foo.com"],
    "methods": ["PUT", "GET"],
    "upstream": {
        "type": "roundrobin",
        "nodes": {
            "127.0.0.1:8888": 1
        }
    }
}'

2.尝试请求http://foo.com/apisix/admin/user/login

curl 'http://foo.com/apisix/admin/user/login' \
  --data-raw '{"username":"admin","password":"admin"}' \
  --compressed \
  --insecure -v

What's the actual result? (including assertion message & call stack if applicable)

返回401。观察logs/error.log发现，请求被认为是apisix admin的请求，被转发到了apisix admin模块。因为请求没有带key，所有返回401

What's the expected result?

请求应该转发到127.0.0.1:8888

[Firstsawyou]

To use APISIX proxy Dashboard, you need to set enable admin to false (because the path of the Admin API and the path of the Manager API are the same, not setting it to false will request to apis of Admin API), and then follow the normal route configuration.

[frf12]

To use APISIX proxy Dashboard, you need to set enable admin to false (because the path of the Admin API and the path of the Manager API are the same, not setting it to false will request to apis of Admin API), and then follow the normal route configuration.

这能解决使用apisix代理apisix dashboard的问题。但如果我的服务中正好有个api是/apisix/admin呢，那也只能通过设置apisix.enable_admin为false来解决吗？这似乎不合理？

[Firstsawyou]

这能解决使用apisix代理apisix dashboard的问题。但如果我的服务中正好有个api是/apisix/admin呢，那也只能通过设置apisix.enable_admin为false来解决吗？这似乎不合理？

When apisix.enable_admin is true, /apisix/admin is the unique API interface of apisix, and the custom api cannot be the same.

[tokers]

To use APISIX proxy Dashboard, you need to set enable admin to false (because the path of the Admin API and the path of the Manager API are the same, not setting it to false will request to apis of Admin API), and then follow the normal route configuration.

这能解决使用apisix代理apisix dashboard的问题。但如果我的服务中正好有个api是/apisix/admin呢，那也只能通过设置apisix.enable_admin为false来解决吗？这似乎不合理？

The prefix /apisix/admin are occupied by APISIX when the admin api enabled. Try to avoid using it when you design your APIs.

@Firstsawyou I think we can add some documents to remind users.

[Firstsawyou]

he prefix /apisix/admin are occupied by APISIX when the admin api enabled. Try to avoid using it when you design your APIs.

@Firstsawyou I think we can add some documents to remind users.

agree.

[spacewander]

It's better to use a separate port for apisix admin:

apisix/conf/config-default.yaml

Line 68 in 728df41

# port_admin: 9180 # use a separate port

We want to make it the default months ago:
https://lists.apache.org/thread.html/rfb780891c940f4930240570d0170fad154a14d7b582ca60b4eae7524%40%3Cdev.apisix.apache.org%3E

But people can't accept such a break change in a minor version.