Skip to content

Conversation

juzhiyuan
Copy link
Member

What this PR does / why we need it:

added users to PoweredBy

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Yiyiyimu
Copy link
Member

do we need to update the icon wall at the same time

@juzhiyuan
Copy link
Member Author

do we need to update the icon wall at the same time

Not in this PR if needed.

1. <a href="https://www.daocloud.io/" rel="nofollow">DaoCloud</a>
1. <a href="http://dian.so/" rel="nofollow">小电科技</a>
1. <a href="https://www.didachuxing.com/" rel="nofollow">嘀嗒出行</a>
1. <a href="https://www.dasouche.com/" rel="nofollow">dasouche 大搜车</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disorder?

1. <a href="https://www.xin.com/" rel="nofollow">Xin 优信二手车</a>
1. <a href="https://xueqiu.com/" rel="nofollow">雪球</a>
1. <a href="https://open.youtu.qq.com/" rel="nofollow">Youtu 腾讯优图</a>
1. <a href="https://www.zuzuche.com/" rel="nofollow">zuzuche 租租车</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disorder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@membphis
Copy link
Member

@juzhiyuan please merge the master branch

@idbeta you can take a look the ci too: https://github.com/apache/apisix/pull/3573/checks?check_run_id=1869908569#step:10:703

@membphis
Copy link
Member

image

@juzhiyuan
Copy link
Member Author

https://github.com/apache/apisix/blob/1abda84d0b9bff24ed8f74f9c2ec7d9b9f99163a/doc/powered-by.md

cc @membphis to take a look at the latest commit.

@membphis
Copy link
Member

@Yiyiyimu please take a look at the output of Chaos Test: https://github.com/apache/apisix/pull/3573/checks?check_run_id=1944989987#step:9:117

8. <a href="https://www.daocloud.io/" rel="nofollow">DaoCloud</a>
9. <a href="http://dian.so/" rel="nofollow">小电科技</a>
10. <a href="https://www.didachuxing.com/" rel="nofollow">嘀嗒出行</a>
11. <a href="https://www.dasouche.com/" rel="nofollow">dasouche 大搜车</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disorder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

What happened 😳

27. <a href="https://www.meizu.com/" rel="nofollow">Meizu 魅族</a>
28. <a href="https://www.mingyuanyun.com/" rel="nofollow">明源云客</a>
29. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
30. <a href="https://open.youtu.qq.com/" rel="nofollow">Youtu 腾讯优图</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ordered with youtu?

23. <a href="https://www.ihomefnt.com/" rel="nofollow">ihomefnt 艾佳生活</a>
24. <a href="https://www.jiandanxinli.com/" rel="nofollow">jiandanxinli 简单心理</a>
25. <a href="https://www.ke.com/" rel="nofollow">ke.com 贝壳找房</a>
26. 2. 2. 1. <a href="https://jr.ly.com/" rel="nofollow">jr.ly 同程金服</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use 2. 2. 1.?

1. <a href="https://www.mingyuanyun.com/" rel="nofollow">明源云客</a>
1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
1. <a href="http://www.163.com" rel="nofollow">Netease 网易</a>
1. <a href="https://open.youtu.qq.com/" rel="nofollow">Youtu 腾讯优图</a>
Copy link
Member

@spacewander spacewander Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ordered as Youtu?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer using QQ 🤔

Copy link
Member

@Yiyiyimu Yiyiyimu Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer using QQ 🤔

Maybe Tencent could be better than QQ 🤣


Or Tencent Youtu. See https://ai.qq.com/hr/youtu.shtml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, links in this PR are ordered according to the domain 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it 😬

@idbeta
Copy link
Contributor

idbeta commented Feb 23, 2021

@juzhiyuan please merge the master branch

@idbeta you can take a look the ci too: https://github.com/apache/apisix/pull/3573/checks?check_run_id=1869908569#step:10:703

sorry, I did not find the reason for the failure. It seems that the case is unstable. @syzh and @spacewander Can you check it?

t/node/invalid-route.t                   (Wstat: 0 Tests: 18 Failed: 3)
  Failed tests:  16-18
  Parse errors: No plan found in TAP output

@spacewander
Copy link
Member

@idbeta
Should be solved by #3609.

@spacewander spacewander merged commit 3be910d into master Feb 23, 2021
@spacewander spacewander deleted the juzhiyuan-patch-1 branch February 23, 2021 03:59
@idbeta
Copy link
Contributor

idbeta commented Feb 23, 2021

@idbeta
Should be solved by #3609.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants