Use http:// in GCS integration test instead of insecure TLS #2632
Conversation
tustvold
force-pushed
the
gcs-http
branch
2 times, most recently
from
9a604c3 to
c1ba241
Compare
| @@ -116,18 +97,16 @@ jobs: | |||
| AWS_SECRET_ACCESS_KEY: test | |||
| AWS_ENDPOINT: http://localstack:4566 | |||
| run: | | |||
| cd /tmp | |||
| curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip" | |||
There was a problem hiding this comment.
A happy side-effect of switching to not using the docker runner is the AWS and Azure CLI's are automatically installed (along with Rust) - https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#cli-tools
| @@ -60,54 +60,35 @@ jobs: | |||
| run: cargo clippy -p object_store --all-features --all-targets -- -D warnings | |||
|
|
|||
| # test the crate | |||
| # This runs outside a container to workaround lack of support for passing arguments | |||
There was a problem hiding this comment.
I really tried to avoid this, but I could not find a way around this. We use non-docker runners in other workflows, e.g. miri, integration, coverage, so I think this is probably fine
tustvold
force-pushed
the
gcs-http
branch
3 times, most recently
from
9382e7f to
1262d9d
Compare
tustvold
changed the title
|
Benchmark runs are scheduled for baseline = a9875f5 and contender = 2d3a350. 2d3a350 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?