-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature gate csv functionality #312
Conversation
4694147
to
b3049b1
Compare
b3049b1
to
c69f642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ritchie46 !
I wonder if we should test this in CI so that it doesn't break? When I ran the tests it seems as if one of the doc tests fails without this feature
cargo test -p arrow --no-default-features
---- src/util/string_writer.rs - util::string_writer (line 25) stdout ----
error[E0432]: unresolved import `arrow::csv`
--> src/util/string_writer.rs:27:5
|
5 | use arrow::csv;
| ^^^^^^^^^^ no `csv` in the root
error: aborting due to previous error
For more information about this error, try `rustc --explain E0432`.
Couldn't compile the test.
failures:
src/util/string_writer.rs - util::string_writer (line 25)
test result: FAILED. 87 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 6.20s
error: test failed, to rerun pass '--doc'
(arrow_dev) alamb@ip-10-0-0-124:~/Software/arrow-rs$
Oh, I missed that one. Will fix that and I will see if I can add a CI change. |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 82.52% 82.52% -0.01%
==========================================
Files 162 162
Lines 44007 44007
==========================================
- Hits 36316 36315 -1
- Misses 7691 7692 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it -- this looks great. Thanks @ritchie46
Thoughts @andygrove / @jorgecarleitao / @nevi-me ?
Which issue does this PR close?
This PR puts the csv parsing logic behind a feature gate. Thereby removing
csv
crate as a dependency. This closes #309.I also added the
csv
feature to the default features to reduce the probability of unexpected changes for users that relied on the default features.