feat: add sort_dictionary #3897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Mar 21, 2023
| arrow-data = { version = "35.0.0", path = "../arrow-data" } | ||
| arrow-schema = { version = "35.0.0", path = "../arrow-schema" } | ||
| arrow-select = { version = "35.0.0", path = "../arrow-select" } | ||
| arrow-ord = { version = "35.0.0", path = "../arrow-ord" } |
There was a problem hiding this comment.
I would really strongly like to avoid this, this is the single heaviest crate
|
Sorry I didn't realise you were working on this, I'm not sure this is a good idea anymore... It helps if you comment on issues you intend on picking up, in case someone else is working on them, or like this one, they don't make sense anymore... |
|
Apologies I must have missed this whilst pruning the backlog, I'll endeavour to write up a proper ticket for how to support this, if this is even something we want to support - the current story for sorted dictionaries is extremely incomplete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part #1218
Rationale for this change
Add
sort_dictionaryandpack_dictionaryoptions.What changes are included in this PR?
Sort element if
sort_dictionaryis true, not implementpack_dictionarybecause I am not sure how to depulicate the array.Are there any user-facing changes?