Skip to content

[Variant] Support Variant to PrimitiveArrow for unsigned integer #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

[Variant] Support Variant to PrimitiveArrow for unsigned integer #8369

merged 2 commits into from
Sep 17, 2025

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Sep 17, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

  • Add support for variant to arrow primitive about unsigned integers
  • Add tests for signed & unsigned integers for variant to arrow primitive

Are these changes tested?

Covered by added unit tests

Are there any user-facing changes?

No

If there are any breaking changes to public APIs, please call them out.

@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Sep 17, 2025
@klion26 klion26 force-pushed the support_primitive_for_unsigned_integer branch from 45bc27a to e3f7679 Compare September 17, 2025 08:47
@klion26 klion26 force-pushed the support_primitive_for_unsigned_integer branch from e3f7679 to 9b1ba68 Compare September 17, 2025 08:50
@klion26
Copy link
Member Author

klion26 commented Sep 17, 2025

@alamb @scovich Please help review this when you're free, thanks.

scovich
scovich approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit 1f77ac5 into apache:main Sep 17, 2025
17 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 17, 2025

Thanks @klion26 and @scovich

@klion26 klion26 deleted the support_primitive_for_unsigned_integer branch September 18, 2025 07:10
@klion26
Copy link
Member Author

klion26 commented Sep 18, 2025

@alamb @scovich thanks for the review and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scovich scovich scovich approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
parquet-variant parquet-variant* crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Variant] Add variant to arrow primitives for unsigned integers
3 participants
@klion26 @alamb @scovich