Skip to content

Commit

Permalink
ARROW-7752: [Release] Enable and test dataset in the verification script
Browse files Browse the repository at this point in the history
We're not testing the dataset feature in the verifications scripts yet.

Closes #6346 from kszucs/dataset-verification and squashes the following commits:

b8530ea <Krisztián Szűcs> Test dataset during the verification

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
  • Loading branch information
kszucs committed Feb 7, 2020
1 parent a563ce3 commit 52e18d5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions dev/release/verify-release-candidate-wheels.bat
Expand Up @@ -75,6 +75,7 @@ python -c "import pyarrow" || EXIT /B 1
python -c "import pyarrow.flight" || EXIT /B 1
python -c "import pyarrow.gandiva" || EXIT /B 1
python -c "import pyarrow.parquet" || EXIT /B 1
python -c "import pyarrow.dataset" || EXIT /B 1

call deactivate

Expand Down
2 changes: 2 additions & 0 deletions dev/release/verify-release-candidate.bat
Expand Up @@ -90,6 +90,7 @@ cmake -G "%GENERATOR%" ^
-DARROW_WITH_BROTLI=ON ^
-DARROW_FLIGHT=ON ^
-DARROW_PYTHON=ON ^
-DARROW_DATASET=ON ^
-DARROW_PARQUET=ON ^
.. || exit /B

Expand Down Expand Up @@ -120,6 +121,7 @@ pushd %ARROW_SOURCE%\python
set PYARROW_CMAKE_GENERATOR=%GENERATOR%
set PYARROW_WITH_FLIGHT=1
set PYARROW_WITH_PARQUET=1
set PYARROW_WITH_DATASET=1
python setup.py build_ext --inplace --bundle-arrow-cpp bdist_wheel || exit /B
py.test pyarrow -v -s --parquet || exit /B

Expand Down
5 changes: 4 additions & 1 deletion dev/release/verify-release-candidate.sh
Expand Up @@ -276,6 +276,7 @@ ${ARROW_CMAKE_OPTIONS:-}
-DARROW_PYTHON=ON
-DARROW_GANDIVA=ON
-DARROW_PARQUET=ON
-DARROW_DATASET=ON
-DPARQUET_REQUIRE_ENCRYPTION=ON
-DARROW_WITH_BZ2=ON
-DARROW_WITH_ZLIB=ON
Expand Down Expand Up @@ -365,6 +366,7 @@ test_python() {

pip install -r requirements.txt -r requirements-test.txt

export PYARROW_WITH_DATASET=1
export PYARROW_WITH_GANDIVA=1
export PYARROW_WITH_PARQUET=1
export PYARROW_WITH_PLASMA=1
Expand Down Expand Up @@ -605,7 +607,8 @@ check_python_imports() {
python -c "import pyarrow.fs"

if [[ "$py_arch" =~ ^3 ]]; then
# Flight and Gandiva are only available for py3
# Flight, Gandiva and Dataset are only available for py3
python -c "import pyarrow.dataset"
python -c "import pyarrow.flight"
python -c "import pyarrow.gandiva"
fi
Expand Down

0 comments on commit 52e18d5

Please sign in to comment.