Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Build fails with noasm build tag #34044

Closed
nwt opened this issue Feb 4, 2023 · 1 comment · Fixed by #34045
Closed

[Go] Build fails with noasm build tag #34044

nwt opened this issue Feb 4, 2023 · 1 comment · Fixed by #34045
Assignees
@nwt
Labels
Component: Go Type: bug
Milestone
12.0.0

Comments

@nwt
Copy link
Contributor

nwt commented Feb 4, 2023

Describe the bug, including details regarding any error messages, version, and platform.

A Go build with the noasm build tag fails.

$ git describe --dirty --tags
apache-arrow-12.0.0.dev-41-gecb1f2e31

$ go build -tags noasm ./...
# github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
arrow/compute/internal/kernels/basic_arithmetic_noasm.go:27:9: undefined: getGoArithmeticOpFloatingSameType
arrow/compute/internal/kernels/basic_arithmetic_noasm.go:35:9: undefined: getGoArithmeticFixedIntOut

Component(s)

Go
@nwt nwt added the Type: bug label Feb 4, 2023
@github-actions github-actions bot mentioned this issue Feb 4, 2023
Merged
@zeroshade zeroshade mentioned this issue Feb 6, 2023
Closed
zeroshade pushed a commit that referenced this issue Feb 6, 2023
@nwt
GH-34044: [Go] Fix build with noasm tag (#34045)
6294a73 
Fix the following build failure.

    $ go build -tags noasm ./...
    # github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:27:9: undefined: getGoArithmeticOpFloatingSameType
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:35:9: undefined: getGoArithmeticFixedIntOut

Closes #34044.

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Feb 6, 2023
@zeroshade
Copy link
Member

Issue resolved by pull request 34045
#34045

sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@nwt @sjperkins
apacheGH-34044: [Go] Fix build with noasm tag (apache#34045)
490271a 
Fix the following build failure.

    $ go build -tags noasm ./...
    # github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:27:9: undefined: getGoArithmeticOpFloatingSameType
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:35:9: undefined: getGoArithmeticFixedIntOut

Closes apache#34044.

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade mentioned this issue Feb 13, 2023
Merged
zeroshade added a commit that referenced this issue Feb 14, 2023
@zeroshade
GH-34055: [Go][CI] Add test run in CI that uses noasm tag (#34167)
266f166 
### Rationale for this change
A bug was found in the `noasm` build for the Go lib in #34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: #34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@nwt
apacheGH-34044: [Go] Fix build with noasm tag (apache#34045)
0e304ab 
Fix the following build failure.

    $ go build -tags noasm ./...
    # github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:27:9: undefined: getGoArithmeticOpFloatingSameType
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:35:9: undefined: getGoArithmeticFixedIntOut

Closes apache#34044.

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@zeroshade
apacheGH-34055: [Go][CI] Add test run in CI that uses noasm tag (apac…
ff20650 
…he#34167)

### Rationale for this change
A bug was found in the `noasm` build for the Go lib in apache#34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: apache#34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@nwt @fatemehp
apacheGH-34044: [Go] Fix build with noasm tag (apache#34045)
f200807 
Fix the following build failure.

    $ go build -tags noasm ./...
    # github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:27:9: undefined: getGoArithmeticOpFloatingSameType
    arrow/compute/internal/kernels/basic_arithmetic_noasm.go:35:9: undefined: getGoArithmeticFixedIntOut

Closes apache#34044.

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@zeroshade @fatemehp
apacheGH-34055: [Go][CI] Add test run in CI that uses noasm tag (apac…
4a5b308 
…he#34167)

### Rationale for this change
A bug was found in the `noasm` build for the Go lib in apache#34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: apache#34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwt nwt

Labels
Component: Go Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34044: [Go] Fix build with noasm tag
2 participants
@zeroshade @nwt