Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][CI] Add test run in CI that uses noasm tag #34055

Closed
zeroshade opened this issue Feb 6, 2023 · 0 comments · Fixed by #34167
Closed

[Go][CI] Add test run in CI that uses noasm tag #34055

zeroshade opened this issue Feb 6, 2023 · 0 comments · Fixed by #34167
Assignees
@zeroshade
Labels
Component: Continuous Integration Component: Go Type: enhancement
Milestone
12.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

#34044 found that the build failed with the noasm tag, to prevent this from happening again we should add a CI run to build and test using the noasm tag.

Component(s)

Continuous Integration, Go
@zeroshade zeroshade self-assigned this Feb 6, 2023
zeroshade added a commit to zeroshade/arrow that referenced this issue Feb 13, 2023
@zeroshade
apacheGH-34055: [Go][CI] Add test run in CI that uses noasm tag
9666411
@github-actions github-actions bot mentioned this issue Feb 13, 2023
Merged
zeroshade added a commit that referenced this issue Feb 14, 2023
@zeroshade
GH-34055: [Go][CI] Add test run in CI that uses noasm tag (#34167)
266f166 
### Rationale for this change
A bug was found in the `noasm` build for the Go lib in #34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: #34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Feb 14, 2023
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@zeroshade
apacheGH-34055: [Go][CI] Add test run in CI that uses noasm tag (apac…
ff20650 
…he#34167)

### Rationale for this change
A bug was found in the `noasm` build for the Go lib in apache#34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: apache#34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@zeroshade @fatemehp
apacheGH-34055: [Go][CI] Add test run in CI that uses noasm tag (apac…
4a5b308 
…he#34167)

### Rationale for this change
A bug was found in the `noasm` build for the Go lib in apache#34044 so adding a CI run with the `noasm` tag should prevent that from happening again in the future.

### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add the `noasm` tag to the `go test` command

Updating go.yml to add a `noasm` CI run

### Are there any user-facing changes?
No

* Closes: apache#34055

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Continuous Integration Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34055: [Go][CI] Add test run in CI that uses noasm tag zeroshade/arrow
1 participant
@zeroshade