Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] Merge script should check if issue is milestoned already #36656

Closed
raulcd opened this issue Jul 13, 2023 · 2 comments
Closed

[Dev] Merge script should check if issue is milestoned already #36656

raulcd opened this issue Jul 13, 2023 · 2 comments
Assignees
@raulcd
Labels
Component: Developer Tools Type: enhancement
Milestone
16.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jul 13, 2023

Describe the enhancement requested

A possible improvement of the merge script should be to check if the issue has been already milestoned and prompt the user if that milestone is the correct one.
If the milestone for the issue is different than the default one this could be also prompted to the user.

This can help avoid missing some issues that have to be backported once the feature freeze is in place when merging.

Component(s)

Developer Tools
@assignUser assignUser mentioned this issue Mar 13, 2024
Closed
@assignUser
Copy link
Member

It could also check if the milestone is closed (and we start closing them on rc creation). You can still add stuff to a closed milestone but this could let the merger know that the release manager has to be contacted

raulcd added a commit to raulcd/arrow that referenced this issue Mar 25, 2024
@raulcd
apacheGH-36656: [Dev] Validate in merge script if issue has an assign…
3ea1d08 
…ed milestone already
@github-actions github-actions bot mentioned this issue Mar 25, 2024
Merged
raulcd added a commit to raulcd/arrow that referenced this issue Mar 26, 2024
@raulcd
apacheGH-36656: [Dev] Validate in merge script if issue has an assign…
b31dc46 
…ed milestone already
kou added a commit that referenced this issue Mar 27, 2024
@raulcd @kou
GH-36656: [Dev] Validate in merge script if issue has an assigned mil…
24feab0 
…estone already (#40771)

### Rationale for this change

When we do the feature freeze for the releases or we are adding issues to patch releases we milestone the issues outside the merge script. The merge script should check and prompt if the issue already has a milestone assigned and should maintain the already assigned milestone to the issue.

### What changes are included in this PR?

The merge script checks whether the issue already contains a milestone and if the milestone is different than the current default one it prompts the user to double check that it is the correct one.

### Are these changes tested?

I've tested it locally.

If no milestone or default it prompts as usual
```
Would you like to update the associated issue? (y/n): y
Enter fix version [16.0.0]: 
```

If a different and closed milestone is assigned:
```
=== The assigned milestone is not the default ===
Assigned milestone: 15.0.2
Current milestone: 16.0.0
Please ensure to assign the correct milestone.
The assigned milestone state is closed. Contact the 
Release Manager if it has to be added to a closed Release
Please ensure to assign the correct milestone.
```

### Are there any user-facing changes?

No, only for committers and not relevant.
* GitHub Issue: #36656

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Mar 27, 2024

Issue resolved by pull request 40771
#40771

@kou kou added this to the 16.0.0 milestone Mar 27, 2024
@kou kou closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
3 participants
@kou @raulcd @assignUser