Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Docs][MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default #37209

Closed
kevingurney opened this issue Aug 16, 2023 · 2 comments · Fixed by #37211
Closed

[CI][Docs][MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default #37209

kevingurney opened this issue Aug 16, 2023 · 2 comments · Fixed by #37211
Assignees
@kevingurney
Labels
Component: Continuous Integration Component: Documentation Component: MATLAB Type: enhancement
Milestone
14.0.0

Comments

@kevingurney
Copy link
Member

Describe the enhancement requested

Now that the old Feather V1 code and associated build infrastructure has been removed (#37204), it would make sense to start building the new, experimental MATLAB Interface code by default (without needing to explicitly specify -D MATLAB_ARROW_INTERFACE=ON).

If we start building the MATLAB Interface code by default, it would also make sense to remove the MATLAB_ARROW_INTERFACE flag entirely, since setting it to OFF would essentially imply that no code should be built.

Component(s)

MATLAB
@github-actions github-actions bot mentioned this issue Aug 16, 2023
Merged
@kevingurney
Copy link
Member Author

Added label Component: Continuous Integration since resolving this involves updating the matlab_build.sh CI script to no longer specify -D MATLAB_ARROW_INTERFACE=ON.

@kevingurney kevingurney changed the title [MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default [CI][MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default Aug 16, 2023
@kevingurney kevingurney changed the title [CI][MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default [CI][Docs][MATLAB] Remove support for MATLAB_ARROW_INTERFACE flag from CMake build system and build new MATLAB Interface code by default Aug 16, 2023
@kevingurney
Copy link
Member Author

Added label Component: Documentation since resolving this involves updating the MATLAB README.md to no longer mention the -D MATLAB_ARROW_INTERFACE=ON flag.

kou pushed a commit that referenced this issue Aug 17, 2023
@kevingurney
GH-37209: [CI][Docs][MATLAB] Remove support for `MATLAB_ARROW_INTERFA…
4680ca5 
…CE` flag from CMake build system and build new MATLAB Interface code by default (#37211)

### Rationale for this change

Now that the old Feather V1 code and associated build infrastructure has been removed (#37204), it makes sense to start building the new, experimental MATLAB Interface code by default (without needing to [explicitly specify `-D MATLAB_ARROW_INTERFACE=ON`](https://github.com/apache/arrow/tree/main/matlab#build)).

This pull request removes the `MATLAB_ARROW_INTERFACE` flag entirely, since setting it to `OFF` when we are building the MATLAB Interface code by default would essentially imply that no code should be built.

### What changes are included in this PR?

1. Removed mention of `MATLAB_ARROW_INTERFACE` flag from MATLAB `README.md`.
2. Removed conditional check for `MATLAB_ARROW_INTERFACE` flag from MATLAB `CMakeLists.txt`.
3. Removed `MATLAB_ARROW_INTERFACE` flag from `matlab_build.sh` CI script.

### Are these changes tested?

Yes.

The MATLAB Interface is building as expected by default on my Debian 11 machine.

### Are there any user-facing changes?

Yes.

1. The experimental MATLAB Interface APIs will now be built by default without users explicitly specifying `-D MATLAB_ARROW_INTERFACE=ON` to `cmake`.
2. If users specify a value for `MATLAB_ARROW_INTERFACE`, the value will be ignored by the CMake build system.
* Closes: #37209

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 17, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kevingurney @loicalleyne
apacheGH-37209: [CI][Docs][MATLAB] Remove support for `MATLAB_ARROW_I…
3d466db 
…NTERFACE` flag from CMake build system and build new MATLAB Interface code by default (apache#37211)

### Rationale for this change

Now that the old Feather V1 code and associated build infrastructure has been removed (apache#37204), it makes sense to start building the new, experimental MATLAB Interface code by default (without needing to [explicitly specify `-D MATLAB_ARROW_INTERFACE=ON`](https://github.com/apache/arrow/tree/main/matlab#build)).

This pull request removes the `MATLAB_ARROW_INTERFACE` flag entirely, since setting it to `OFF` when we are building the MATLAB Interface code by default would essentially imply that no code should be built.

### What changes are included in this PR?

1. Removed mention of `MATLAB_ARROW_INTERFACE` flag from MATLAB `README.md`.
2. Removed conditional check for `MATLAB_ARROW_INTERFACE` flag from MATLAB `CMakeLists.txt`.
3. Removed `MATLAB_ARROW_INTERFACE` flag from `matlab_build.sh` CI script.

### Are these changes tested?

Yes.

The MATLAB Interface is building as expected by default on my Debian 11 machine.

### Are there any user-facing changes?

Yes.

1. The experimental MATLAB Interface APIs will now be built by default without users explicitly specifying `-D MATLAB_ARROW_INTERFACE=ON` to `cmake`.
2. If users specify a value for `MATLAB_ARROW_INTERFACE`, the value will be ignored by the CMake build system.
* Closes: apache#37209

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevingurney kevingurney

Labels
Component: Continuous Integration Component: Documentation Component: MATLAB Type: enhancement
Projects
None yet
Milestone
14.0.0
2 participants
@kou @kevingurney