Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Support IReadOnlyList on remaining scalar types #39223

Closed
CurtHagenlocher opened this issue Dec 14, 2023 · 0 comments · Fixed by #39224
Closed

[C#] Support IReadOnlyList on remaining scalar types #39223

CurtHagenlocher opened this issue Dec 14, 2023 · 0 comments · Fixed by #39224
Assignees
@CurtHagenlocher
Labels
Component: C# Type: enhancement
Milestone
15.0.0

Comments

@CurtHagenlocher
Copy link
Contributor

Describe the enhancement requested

IReadOnlyList has been implemented on most of the scalar types but not on Decimal128Array, Decimal256Array, DurationArray or FixedSizeBinaryArray.

Component(s)

C#
@CurtHagenlocher CurtHagenlocher self-assigned this Dec 14, 2023
@github-actions github-actions bot mentioned this issue Dec 14, 2023
Merged
CurtHagenlocher added a commit that referenced this issue Dec 14, 2023
@CurtHagenlocher
GH-39223: [C#] Support IReadOnlyList<T?> on remaining scalar types (#…
431c4ea 
…39224)

### What changes are included in this PR?

Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>.
Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList<string> and IReadOnlyList<byte[]>.
FixedLengthBinaryArray implements IReadOnlyList<byte[]>.
DurationArray implements IReadOnlyList<TimeSpan?>.

Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more.

### Are these changes tested?

Yes.
* Closes: #39223

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 15.0.0 milestone Dec 14, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@CurtHagenlocher @clayburn
apacheGH-39223: [C#] Support IReadOnlyList<T?> on remaining scalar ty…
3661155 
…pes (apache#39224)

### What changes are included in this PR?

Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>.
Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList<string> and IReadOnlyList<byte[]>.
FixedLengthBinaryArray implements IReadOnlyList<byte[]>.
DurationArray implements IReadOnlyList<TimeSpan?>.

Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more.

### Are these changes tested?

Yes.
* Closes: apache#39223

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@CurtHagenlocher @dgreiss
apacheGH-39223: [C#] Support IReadOnlyList<T?> on remaining scalar ty…
0e1ef39 
…pes (apache#39224)

### What changes are included in this PR?

Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>.
Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList<string> and IReadOnlyList<byte[]>.
FixedLengthBinaryArray implements IReadOnlyList<byte[]>.
DurationArray implements IReadOnlyList<TimeSpan?>.

Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more.

### Are these changes tested?

Yes.
* Closes: apache#39223

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CurtHagenlocher CurtHagenlocher

Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39223: [C#] Support IReadOnlyList<T?> on remaining scalar types CurtHagenlocher/arrow
1 participant
@CurtHagenlocher