GH-39223: [C#] Support IReadOnlyList<T?> on remaining scalar types #39224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 431c4ea. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…pes (apache#39224) ### What changes are included in this PR? Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>. Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList<string> and IReadOnlyList<byte[]>. FixedLengthBinaryArray implements IReadOnlyList<byte[]>. DurationArray implements IReadOnlyList<TimeSpan?>. Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more. ### Are these changes tested? Yes. * Closes: apache#39223 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pes (apache#39224) ### What changes are included in this PR? Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>. Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList<string> and IReadOnlyList<byte[]>. FixedLengthBinaryArray implements IReadOnlyList<byte[]>. DurationArray implements IReadOnlyList<TimeSpan?>. Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more. ### Are these changes tested? Yes. * Closes: apache#39223 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Decimal128Array implements IReadOnlyList<SqlDecimal?> and IReadOnlyList<byte[]>.
Decimal256Array implements IReadOnlyList<SqlDecimal?>, IReadOnlyList and IReadOnlyList<byte[]>.
FixedLengthBinaryArray implements IReadOnlyList<byte[]>.
DurationArray implements IReadOnlyList<TimeSpan?>.
Also removes #ifs which are no longer relevant now that netstandard13 isn't being built any more.
Are these changes tested?
Yes.