-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-4263: [Rust] Donate DataFusion #3399
Conversation
Could you update https://github.com/apache/arrow/blob/master/dev/release/00-prepare.sh#L101-L105 ? |
Thanks @kou .. I've actually been trying to figure out Is it too late now to rebase this PR? |
You can squash the branch this way
If you make a mistake you can recover using the reflog. see also https://ohshitgit.com/ |
(Generally once you have merge commits in a branch, normal rebasing is off the table) |
Can you move the test data files to arrow-testing?
|
@wesm I have created a PR against arrow-testing: |
Could you re-add a change for https://github.com/apache/arrow/blob/master/dev/release/00-prepare.sh#L101-L105 ? |
Once #3547 and apache/arrow-testing#1 are merged, I can delete the test data file from this PR and update the tests to use the version from arrow-testing |
The IP clearance vote is passed |
I just merged apache/arrow-testing#1. Let me know when this is ready to merge =) |
…e I can't trace where the original data came from
@wesm Tests pass for me locally so hopefully we're good to go once Travis has run ... |
Travis is happy |
Appveyor is happy too. Let's do this! |
👍 |
Excited to see this merged, thanks @andygrove |
This PR is to donate the DataFusion source code (assuming that the vote passes!) Author: Andy Grove <andygrove73@gmail.com> Closes #3399 from andygrove/ARROW-4263 and squashes the following commits: 990d06f <Andy Grove> formatting 6603091 <Andy Grove> update path again, update testing submodule 38fa63b <Andy Grove> remove test csv file, update tests to use test data from new testing submodule 16e4cff <Andy Grove> remove test csv file, update tests to use test data from new testing submodule 91f6e90 <Andy Grove> update example to use new data file 4ebeee5 <Andy Grove> formatting ae88a90 <Andy Grove> convert tests to use new test data file that was randomly generated d7bea8e <Andy Grove> update test to use uk_cities.csv and remove people.csv 061d788 <Andy Grove> remove unused test data files f60e50d <Andy Grove> remove unused test data files, manually recreate uk_cities.csv because I can't trace where the original data came from 28d914a <Andy Grove> Update 00-prepare.sh to handle datafusion versioning c4e1a26 <Andy Grove> DataFusion Donation
This PR is to donate the DataFusion source code (assuming that the vote passes!)