ARROW-4590: [Rust] Add explicit SIMD vectorization for comparison ops in "array_ops" #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried for a long time to re-organize the traits in
datatypesto keep the implementation as clean as possible but could never quite get anything better than what I currently have. Once this is merged others might have some ideas in this area (@sunchao in particular).I'm going to open another JIRA for updating the divide kernel as I didn't want this PR getting too big and there are some issues specific to that kernel (dealing with the padded region while checking for 0's in the right operand, etc.).