Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36969: [C++] Update ABSEIL to address compile error on GCC 13 #43147

Closed
wants to merge 3 commits into from

Conversation

amol-
Copy link
Member

@amol- amol- commented Jul 4, 2024

Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a <cstdint> include, this PR addresses the issue by updating ABSEIL to version nearest to the one currently in use that includes the fix.

There have been past reports for this issue too: #36969

What changes are included in this PR?

Downloaded ABSL version updated from 20211102.0 to 20220623.2

Are these changes tested?

They are tested by the existing compile infrastructure and testsuite

Are there any user-facing changes?

No, all behaviours should remain the same

@amol-
Copy link
Member Author

amol- commented Jul 4, 2024

@github-actions crossbow submit -g cpp

Copy link

github-actions bot commented Jul 4, 2024

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9792193996

@amol-
Copy link
Member Author

amol- commented Jul 4, 2024

Seems that there are ABI changes already between the two versions

/usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20220623::base_internal::StrError[abi:cxx11](int)'

@amol-
Copy link
Member Author

amol- commented Jul 4, 2024

Now R builds correctly but GLib & Ruby fails to build with

(/usr/local/lib/libarrow_flight.so.1700: undefined symbol: _ZN4absl12lts_2022062313base_internal8StrErrorB5cxx11Ei)

@amol-
Copy link
Member Author

amol- commented Jul 4, 2024

@github-actions crossbow submit -g cpp

Copy link

github-actions bot commented Jul 4, 2024

Revision: 1c8a924

Submitted crossbow builds: ursacomputing/crossbow @ actions-f0d84d8140

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@amol-
Copy link
Member Author

amol- commented Jul 4, 2024

@github-actions crossbow submit -g r

@apache apache deleted a comment from github-actions bot Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Revision: 1c8a924

Submitted crossbow builds: ursacomputing/crossbow @ actions-079c9bc333

Task Status
r-binary-packages GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

@amol-
Copy link
Member Author

amol- commented Jul 5, 2024

The cpp-thread-sanitizer might be unrelated, the process seems to be killed by the OS:

Running arrow-compute-internals-test, redirecting output into /build/cpp/build/test-logs/arrow-compute-internals-test.txt (attempt 1/1)
/arrow/cpp/build-support/run-test.sh: line 88: 14285 Killed                  $TEST_EXECUTABLE "$@" > $LOGFILE.raw 2>&1
Running main() from _deps/googletest-src/googletest/src/gtest_main.cc

@amol-
Copy link
Member Author

amol- commented Jul 5, 2024

@github-actions crossbow submit r-binary-packages

Copy link

github-actions bot commented Jul 5, 2024

Revision: c35725c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d1ac06af75

Task Status
r-binary-packages GitHub Actions

@felipecrv
Copy link
Contributor

@amol- can you rebase to get the contents of #43219? You might have a higher chance of getting the build to pass.

@amol-
Copy link
Member Author

amol- commented Jul 16, 2024

@amol- can you rebase to get the contents of #43219? You might have a higher chance of getting the build to pass.

👍 I'll try next week as soon as I'm back home

assignUser pushed a commit that referenced this pull request Jul 26, 2024
### Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.

There have been past reports for this issue too: #36969 

This is a more minimal fix that tries to avoid the complexity of previous attempts like  #43147 and #37066 which involved updating Abseil and facing additional issues to fix.

### What changes are included in this PR?

Add the missing include when GCC>=13

### Are these changes tested?

They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.

### Are there any user-facing changes?

No, all behaviours should remain the same
* GitHub Issue: #43228

Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
jonkeane pushed a commit that referenced this pull request Jul 31, 2024
### Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.

There have been past reports for this issue too: #36969 

This is a more minimal fix that tries to avoid the complexity of previous attempts like  #43147 and #37066 which involved updating Abseil and facing additional issues to fix.

### What changes are included in this PR?

Add the missing include when GCC>=13

### Are these changes tested?

They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.

### Are there any user-facing changes?

No, all behaviours should remain the same
* GitHub Issue: #43228

Lead-authored-by: Alessandro Molina <alessandro@molina.fyi>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@amol-
Copy link
Member Author

amol- commented Sep 26, 2024

Closing as the issue has been solved

@amol- amol- closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants