-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36969: [C++] Update ABSEIL to address compile error on GCC 13 #43147
Conversation
@github-actions crossbow submit -g cpp |
|
Seems that there are ABI changes already between the two versions
|
Now R builds correctly but
|
@github-actions crossbow submit -g cpp |
Revision: 1c8a924 Submitted crossbow builds: ursacomputing/crossbow @ actions-f0d84d8140 |
@github-actions crossbow submit -g r |
Revision: 1c8a924 Submitted crossbow builds: ursacomputing/crossbow @ actions-079c9bc333 |
The
|
@github-actions crossbow submit r-binary-packages |
Revision: c35725c Submitted crossbow builds: ursacomputing/crossbow @ actions-d1ac06af75
|
### Rationale for this change When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include. There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix. ### What changes are included in this PR? Add the missing include when GCC>=13 ### Are these changes tested? They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds. ### Are there any user-facing changes? No, all behaviours should remain the same * GitHub Issue: #43228 Lead-authored-by: Alessandro Molina <alessandro@molina.fyi> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include. There have been past reports for this issue too: #36969 This is a more minimal fix that tries to avoid the complexity of previous attempts like #43147 and #37066 which involved updating Abseil and facing additional issues to fix. ### What changes are included in this PR? Add the missing include when GCC>=13 ### Are these changes tested? They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds. ### Are there any user-facing changes? No, all behaviours should remain the same * GitHub Issue: #43228 Lead-authored-by: Alessandro Molina <alessandro@molina.fyi> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Closing as the issue has been solved |
Rationale for this change
When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a
<cstdint>
include, this PR addresses the issue by updating ABSEIL to version nearest to the one currently in use that includes the fix.There have been past reports for this issue too: #36969
What changes are included in this PR?
Downloaded ABSL version updated from 20211102.0 to 20220623.2
Are these changes tested?
They are tested by the existing compile infrastructure and testsuite
Are there any user-facing changes?
No, all behaviours should remain the same