ARROW-6694: [Rust] [DataFusion] Integration tests now use physical query plan #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyhoran
requested changes
Oct 5, 2019
paddyhoran
requested changes
Oct 5, 2019
| match expr { | ||
| &Expr::Literal(ref scalar_value) => { | ||
| let limit: usize = match scalar_value { | ||
| ScalarValue::Int8(x) => Ok(*x as usize), |
There was a problem hiding this comment.
I think you need check that the signed integers are positive, right?
There was a problem hiding this comment.
Nice catch! ... this was copied over from the existing (soon to be legacy) query execution logic ... now fixed. Also used a more appropriate variable name than x and fixed the error messages.
| ScalarValue::UInt32(x) => Ok(*x as usize), | ||
| ScalarValue::UInt64(x) => Ok(*x as usize), | ||
| _ => Err(ExecutionError::ExecutionError( | ||
| "Limit only support positive integer literals" |
| ))) | ||
| } | ||
| _ => Err(ExecutionError::ExecutionError( | ||
| "Limit only support positive integer literals".to_string(), |
andygrove
added a commit
that referenced
this pull request
Oct 8, 2019
…cal plan As discussed in the mailing list, this PR removes the legacy code that executed queries directly from the LogicalPlan. This code is not needed now that the new query execution code based on a physical query plan has reached feature parity. We should merge #5582 first, and rebase. Closes #5583 from andygrove/ARROW-6695 and squashes the following commits: 6105ea9 <Andy Grove> Rebase 195ed76 <Andy Grove> Remove legacy relations 8a7a0d2 <Andy Grove> Remove legacy code that executed queries directly from a logical plan Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests now use physical query plan instead of executing directly from the logical plan.
As part of this PR I added the mapping from logical to physical plan for LIMIT which I somehow missed when creating the PR for the LIMIT physical plan.