Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5809: [CI] [Rust] Travis runs dockerized Rust build #5586

Closed
wants to merge 11 commits into from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 6, 2019

The specific nightly version of Rust is installed when building the Docker image, so it no longer needs to be downloaded on every run.

I have removed tarpaulin (code coverage) for now since it has been failing for many months anyway and there are challenges to getting it working with docker-compose. I will create a separate story for this.

@github-actions
Copy link

github-actions bot commented Oct 6, 2019

@andygrove andygrove requested a review from kszucs October 6, 2019 16:55
@andygrove andygrove added Component: Rust WIP PR is work in progress labels Oct 6, 2019
@andygrove andygrove changed the title ARROW-5809: [CI] [Rust] Travis runs dockerized Rust build [WIP] ARROW-5809: [CI] [Rust] Travis runs dockerized Rust build Oct 6, 2019
@andygrove andygrove removed the WIP PR is work in progress label Oct 6, 2019
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
We can merge this once CI is green.

I've pushed some small changes:

  • `...` -> $(...)
  • rust:1.38.0-stretch -> buster

@codecov-io
Copy link

Codecov Report

Merging #5586 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5586      +/-   ##
==========================================
- Coverage   89.18%   88.82%   -0.37%     
==========================================
  Files         924      985      +61     
  Lines      127616   132477    +4861     
  Branches     1501     1501              
==========================================
+ Hits       113817   117670    +3853     
- Misses      13434    14442    +1008     
  Partials      365      365
Impacted Files Coverage Δ
cpp/src/arrow/json/converter.cc 90.05% <0%> (-1.76%) ⬇️
cpp/src/arrow/json/chunked_builder.cc 80% <0%> (-1.67%) ⬇️
python/pyarrow/plasma.py 58.9% <0%> (-1.37%) ⬇️
cpp/src/arrow/compute/compute_test.cc 100% <0%> (ø) ⬆️
r/R/feather.R 63.33% <0%> (ø)
r/src/recordbatch.cpp 87.76% <0%> (ø)
r/src/table.cpp 87.61% <0%> (ø)
r/R/array-data.R 20% <0%> (ø)
r/R/filesystem.R 70.45% <0%> (ø)
r/R/list.R 100% <0%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10838a0...6fe3535. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants