Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6696: [Rust] [DataFusion] Implement simple math operations in physical query plan #5599

Closed
wants to merge 1 commit into from
Closed

ARROW-6696: [Rust] [DataFusion] Implement simple math operations in physical query plan #5599

wants to merge 1 commit into from

Conversation

kyle-mccarthy
Copy link
Contributor

@kyle-mccarthy kyle-mccarthy commented Oct 7, 2019 •
edited by andygrove
Loading

JIRA Issue: ARROW-6696

Added the arithmetic ops for the BinaryExpr.

@andygrove andygrove changed the title [Rust] [DataFusion] Implement simple math operations in physical query plan ARROW-6606: [Rust] [DataFusion] Implement simple math operations in physical query plan Oct 7, 2019
@andygrove andygrove changed the title ARROW-6606: [Rust] [DataFusion] Implement simple math operations in physical query plan ARROW-6696: [Rust] [DataFusion] Implement simple math operations in physical query plan Oct 7, 2019
@github-actions
Copy link

github-actions bot commented Oct 7, 2019

https://issues.apache.org/jira/browse/ARROW-6696

@kyle-mccarthy
Copy link
Contributor Author

Note that I renamed to comparison_op macro to binary_array_op since it can be used for the arithmetic ops as well. I don't think this would be a BC since the macro isn't exported, but LMK if you would prefer that I create another macro instead.

andygrove
andygrove approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kyle-mccarthy

nevi-me
nevi-me approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove closed this in ec27946 Oct 8, 2019
@kyle-mccarthy kyle-mccarthy deleted the ARROW-6696 branch October 8, 2019 14:27
@kyle-mccarthy kyle-mccarthy restored the ARROW-6696 branch October 8, 2019 14:29
@asfimport asfimport mentioned this pull request Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevi-me nevi-me nevi-me approved these changes

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
Component: Rust - DataFusion Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyle-mccarthy @andygrove @nevi-me