ARROW-8855: [Rust] [Integration] Complete record_batch_from_json types #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing types in `record_batch_from_json`. This however excludes list types, we can add them separately.
|
@andygrove this fixes the |
andygrove
approved these changes
May 21, 2020
andygrove
pushed a commit
that referenced
this pull request
May 21, 2020
When an `ipc::MessageHeader` == `NONE` we should return 'Ok(None)' instead of an error. Please merge this after #7242 Closes #7243 from nevi-me/ARROW-8856 Authored-by: Neville Dipale <nevilledips@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
May 26, 2020
Adds missing types in `record_batch_from_json`. This however excludes list types, we can add them separately. Closes apache#7242 from nevi-me/ARROW-8855 Authored-by: Neville Dipale <nevilledips@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
May 26, 2020
When an `ipc::MessageHeader` == `NONE` we should return 'Ok(None)' instead of an error. Please merge this after apache#7242 Closes apache#7243 from nevi-me/ARROW-8856 Authored-by: Neville Dipale <nevilledips@gmail.com> Signed-off-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing types in
record_batch_from_json.This however excludes list types, we can add them separately.