Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3265: Fix avrogen code generation for Avro namespaces #1423

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

almazik
Copy link
Contributor

@almazik almazik commented Dec 12, 2021

Fix for uncompilable code generation in case when the namespace ends with ".Avro".

Make sure you have checked all steps below.

Jira

Tests

  • [ x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

NOTE: Tests are suppressed for .NET Core environment. I reviewed the changes I've added to tests but unfortunately could not run them on MacOS / .NET 5-6. I did manually tested the changes in logic though.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Fixes an issue when the generated code is uncompilable if the namespace to be generated ends with ".Avro"
@github-actions github-actions bot added the C# label Dec 12, 2021
Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the contribution!

@RyanSkraba RyanSkraba merged commit bbe3db4 into apache:master Dec 22, 2021
RyanSkraba pushed a commit that referenced this pull request Dec 22, 2021
Fixes an issue when the generated code is uncompilable if the namespace to be generated ends with ".Avro"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants