AVRO-3771: [Rust] Logging flood during validate method #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
changed the title
…gainst a single schema If validating against several schemata then it is expected that it should fail for all but one most of the time, so log it as debug Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
pushed a commit
that referenced
this pull request
Jun 7, 2023
* fix: lower log level for validation errors * AVRO-3771: [Rust] Log the validation failure as error if validating against a single schema If validating against several schemata then it is expected that it should fail for all but one most of the time, so log it as debug Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> --------- Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Co-authored-by: Fedor Telnov <f.telnov@picodata.io> Co-authored-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> (cherry picked from commit 7bf4f5e)
|
Thank you, @ftelnov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowers logging level for validate with schemata method to debug level to avoid noisy logs.
Associated issue in JIRA: https://issues.apache.org/jira/browse/AVRO-3771