Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix import of java-example project #2875

Merged
merged 2 commits into from
May 14, 2024

Conversation

tomohavvk
Copy link
Contributor

What is the purpose of the change

This pull request addresses the issue concerning the importing of the java-example project, stemming from the error Cannot resolve plugin org.apache.maven.plugins:maven-plugin:1.11.3.

Upon examination, it became evident that the org.apache.maven.plugins:maven-plugin version utilized was sourced from ${avro.version} variable, which is not correct. However, determining the correct version of org.apache.maven.plugins:maven-plugin proved elusive.

Also the getting-started-java tutorial have no any mentions about org.apache.maven.plugins:maven-plugin and i decided to fix the issue by removing the unresolved plugin org.apache.maven.plugins:maven-plugin.

Consequently, the project importing proceeded smoothly, and the goal avro:schema was able to generate the sources from the user.avsc file without any further impediments.

Verifying this change

The change is to fix import of java-example project

Documentation

Does this pull request introduce a new feature? no

@martin-g
Copy link
Member

martin-g commented Apr 29, 2024

I have the feeling the original author really wanted to use the Avro Maven plugin (

<artifactId>avro-maven-plugin</artifactId>
<packaging>maven-plugin</packaging>
)

@tomohavvk
Copy link
Contributor Author

@martin-g yes, you may be right. In any case, the necessary plugins are already configured in the pom.xml, and the plugin that I deleted does not affect the assembly of the java-example project. I removed it so that other users can successfully clone the project and play with the source generation without project importing troubles

Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-g martin-g merged commit 74d920e into apache:main May 14, 2024
2 checks passed
@martin-g
Copy link
Member

Thank you, @tomohavvk !

@tomohavvk
Copy link
Contributor Author

@martin-g, thank you for support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants