Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2392: enable joda micros logical types supports #517

Merged
merged 1 commit into from
May 31, 2019
Merged

AVRO-2392: enable joda micros logical types supports #517

merged 1 commit into from
May 31, 2019

Conversation

syodage
Copy link

@syodage syodage commented May 10, 2019

Fixing https://issues.apache.org/jira/browse/AVRO-2392

According to the Avro documentation time-micros and timestamp-micros should represent the time instances instead of just Long.

This PR enables generating expected types for time-micros and timestamp-micros logicalType fields.

@probot-autolabeler probot-autolabeler bot added the Java Pull Requests for Java binding label May 10, 2019
@Fokko
Copy link
Contributor

Fokko commented May 10, 2019

@syodage We're expecting to deprecate the support in Avro 1.10. Right no we're testing the release candidate for 1.9. Would switchting to switching to JSR-310 also solve this issue?

https://lists.apache.org/thread.html/54aeffe80fcd05e32bc67e871c9c7b20853395c52b384101a7689d0d@%3Cdev.avro.apache.org%3E

@syodage
Copy link
Author

syodage commented May 10, 2019

@Fokko yes I saw the deprecation annotation, I am looking at improving the Joda time support for the sbt-avro plugin, which uses the 1.8.2, I am working on creating a patch to 1.8.2 branch too so we can use it in the plugin(once the 1.8.3 is released). I am planning to start a thread in the sbt-avro to see how we can migrate to the 1.9.0 once it is released. but still would like to keep it consistent for the users. does it make sense?

@Fokko
Copy link
Contributor

Fokko commented May 29, 2019

I'm comfortable to make this part of 1.9.1. The 1.8.x branch is quite old and there are a lot of security issues over there. There is still Joda support in 1.9.0, but it has to be enabled using a configuration variable. WDYT

@syodage syodage changed the base branch from master to branch-1.9 May 29, 2019 14:22
@syodage syodage changed the base branch from branch-1.9 to master May 29, 2019 14:22
@syodage syodage changed the base branch from master to branch-1.9 May 29, 2019 17:33
@Fokko
Copy link
Contributor

Fokko commented May 31, 2019

Thanks @syodage

@Fokko Fokko merged commit 63d5148 into apache:branch-1.9 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build C# Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants