Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2630: Use apt-get to install perl modules. #736

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

RyanSkraba
Copy link
Contributor

Note: I separated the perl modules installed via apt-get to be in the "perl" section and close to the CPAN installation.

I checked that all of the modules were available with perl -e "use Compress::Zlib" inside the docker.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Non-regression only

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@kojiromike kojiromike merged commit 2b8d730 into apache:master Dec 10, 2019
ecopoesis pushed a commit to ecopoesis/avro that referenced this pull request Jan 8, 2020
Using apt-get to install perl modules in the Dockerfile speeds up the build significantly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants