Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2865: Remove maven 2 support #919

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

RyanSkraba
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler bot added build Java Pull Requests for Java binding labels Jun 19, 2020
@RyanSkraba RyanSkraba requested a review from iemejia June 19, 2020 13:19
@RyanSkraba
Copy link
Contributor Author

@iemejia What do you think -- is this CVE a reason to wait for 1.10.0 RC2 ?

On the one hand, the plexus-util jar with the vulnerability will only be on the machine building avro specific records, and XML injection could only be done from the pom.xml sitting right there in front of the user running maven...

... on the other hand, a lot of build machines are CI (jenkins) and automatic/expensive shared resources.

@iemejia
Copy link
Member

iemejia commented Jun 19, 2020

It makes sense to do a RC2 we should not let security vulnerabilities exposed. Thanks for the PR @RyanSkraba

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit d9fae92 into apache:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants