[BEAM-8816] Option to load balance bundle processing w/ multiple SDK workers #10313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxm
reviewed
Dec 9, 2019
...n/src/test/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactoryTest.java
Outdated
Show resolved
Hide resolved
...ution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
Outdated
Show resolved
Hide resolved
...ution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/test/java/org/apache/beam/sdk/options/ExperimentalOptionsTest.java
Outdated
Show resolved
Hide resolved
| environmentCaches.get(environmentIndex).getUnchecked(executableStage.getEnvironment()); | ||
| client.ref(); | ||
| final LoadingCache<Environment, WrappedSdkHarnessClient> currentCache; | ||
| if (loadBalanceBundles) { |
There was a problem hiding this comment.
Just an idea: Instead of conditionally switching here, could we add an interface to handle the client selection? We could have two implementations, one regular, one for load balancing. Would make the code easier to read here (necessary data structures would go into the implementation) and also avoid runtime checks.
There was a problem hiding this comment.
I also had that idea, maybe as a follow-up.
tweise
force-pushed
the
BEAM-8816.loadBalanceBundles
branch
from
c7573b7
to
c8595ec
Compare
|
CC: @rakeshcusat |
mxm
approved these changes
Dec 16, 2019
|
👍 |
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new pipeline option that allows for bundles of a given executable stage to be processed with any available SDK worker (the default is to process all bundles with the same SDK worker).
https://lists.apache.org/thread.html/59c02d8b8ea849c158deb39ad9d83af4d8fcb56570501c7fe8f79bb2%40%3Cdev.beam.apache.org%3E
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.