-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9359] Switch to Data Catalog client #10917
Conversation
Run SQL PostCommit |
Have you looked at the linkage checker for issues that swapping versions is going to cause? It also looks like we are regressing the package namespace to v1beta1 even though we are increasing the version number. |
This isn't just swapping versions, it's switching to using the java client library, rather than using the gRPC stub and protos directly. How do I run the linkage checker? |
Linkage checker instructions: Line 294 in 76501ab
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM pending linkage checker. Seems there's some lack of clarity around the best way to publicly depend on this functionality.
One thing I noted after testing internally is that |
Result of running the linkage checker script is here: https://gist.github.com/TheNeuralBit/30d4b4a851dcaeed1651cc19fedd3159 I could use some help interpreting the results. |
18f73eb
to
b3b8144
Compare
The GCP Data Catalog docs indicate people should be using this client library, rather than the gRPC stub. |
Run SQL PostCommit |
I pushed a change to replace the StatueRuntimeException with specific gax exceptions. Planning on merging when tests are green. |
the linkage checker results are stale and are picking up warnings due to a jackson version change so it seems like no new linage issues have been reported |
Use DataCatalog client, rather than using the gRPC stub directly.
CC: @kennknowles
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.