Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8106] Add Java 11 container to release and Java 11+V2+Dataflow testing #13374

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

emilymye
Copy link
Contributor

  • Fix java11 container task to actually output a java 11 container (whoops)
  • Add ValidateRunner and Example postcommits against the container
  • Add java11 container to release scripts

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@emilymye
Copy link
Contributor Author

Run seed job

@emilymye
Copy link
Contributor Author

Run Java 11 Examples on Dataflow Runner V2

@emilymye emilymye force-pushed the java11release branch 2 times, most recently from 90ddfa6 to 948a75a Compare November 23, 2020 07:35
@emilymye
Copy link
Contributor Author

R: @TheNeuralBit
R: @kennknowles

After some investigation, I think this is actually the more reliable way created to run Java 11 tests against Java 8 Beam (based on conversation from an old PR - the WIPs mentioned there are closed PRs but the actual code was committed later on. We should go back and fix tests in either case.

To test locally, I ran

./gradlew :runners:google-cloud-dataflow-java:examplesJavaRunnerV2IntegrationTest 
  -PdisableSpotlessCheck=true
  -PcompileAndRunTestsWithJava11
  -PskipCheckerFramework
  -Pjava11Home=...
  -PdataflowProject="..."
  -PdataflowTempRoot="..."
  -PdockerImageRoot="..."

@kennknowles kennknowles merged commit fa7c5fc into apache:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants