Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9379] Vendor Calcite 1.26.0 #14146

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Conversation

apilloud
Copy link
Member

@apilloud apilloud commented Mar 4, 2021

Verified with manual inspection and linkage checks:

./gradlew -p vendor/calcite-1_26_0 -PvendoredDependenciesOnly  publishToMavenLocal
./gradlew -Ppublishing -PvendoredDependenciesOnly -PjavaLinkageArtifactIds=beam-vendor-calcite-1_26_0:0.1-SNAPSHOT :checkJavaLinkage

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@apilloud
Copy link
Member Author

apilloud commented Mar 4, 2021

R: @kennknowles
This is based on #12962.
cc: @nielsbasjes

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice verification. Given that, we can merge and release.

You could verify yet more by publishing to your local and then switching to a branch that upgrades the codebase.

@apilloud
Copy link
Member Author

apilloud commented Mar 5, 2021

Run Python PreCommit

@apilloud
Copy link
Member Author

apilloud commented Mar 5, 2021

I have the other half of this building, test failures look Beam related. I'll plan to merge and start the release shortly.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #14146 (e4d09bb) into master (2e9e9a8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14146      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         469      469              
  Lines       58473    58493      +20     
==========================================
+ Hits        48561    48577      +16     
- Misses       9912     9916       +4     
Impacted Files Coverage Δ
...srcs/sdks/python/apache_beam/io/gcp/tests/utils.py
...m/examples/snippets/transforms/elementwise/keys.py
...apache_beam/testing/benchmarks/nexmark/__init__.py
.../srcs/sdks/python/apache_beam/runners/sdf_utils.py
.../build/srcs/sdks/python/apache_beam/tools/utils.py
...on/apache_beam/ml/gcp/naturallanguageml_test_it.py
...he_beam/examples/cookbook/multiple_output_pardo.py
...nippets/transforms/aggregation/groupintobatches.py
...python/apache_beam/typehints/typecheck_test_py3.py
...am/examples/snippets/transforms/aggregation/sum.py
... and 928 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9e9a8...e4d09bb. Read the comment docs.

@apilloud apilloud merged commit 0f52187 into apache:master Mar 8, 2021
@apilloud apilloud deleted the vendorcalcite branch March 8, 2021 19:00
@apilloud apilloud mentioned this pull request Sep 7, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants